[webkit-changes] [WebKit/WebKit] 98fb77: [Site Isolation] Popup menus are incorrectly offset

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98fb7757cc6a4966bd71a0105938f6f97d9e8abe
      https://github.com/WebKit/WebKit/commit/98fb7757cc6a4966bd71a0105938f6f97d9e8abe
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp

  Log Message:
  -----------
  [Site Isolation] Popup menus are incorrectly offset
https://bugs.webkit.org/show_bug.cgi?id=272694
rdar://126497992

Reviewed by Alex Christensen.

When a popup menu is opened from an isolated iframe the menu will be offset because iframe processes
cannot convert to root view coordinates. To convert to root view coordinates we need to convert from
the parent of each root frame.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenuFromFrame):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::show):

Canonical link: https://commits.webkit.org/277523@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications