[webkit-changes] [WebKit/WebKit] 84ebf5: heap-use-after-free | Style::Resolver::setViewTran...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84ebf5141996487b18210ca5c38429477fc7eb23
      https://github.com/WebKit/WebKit/commit/84ebf5141996487b18210ca5c38429477fc7eb23
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    A LayoutTests/fast/css/view-transitions-update-pseudo-element-crash-expected.txt
    A LayoutTests/fast/css/view-transitions-update-pseudo-element-crash.html
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  heap-use-after-free | Style::Resolver::setViewTransitionStyles; WebCore::ViewTransition::updatePseudoElementStyles; WebCore::ViewTransition::activateViewTransition
https://bugs.webkit.org/show_bug.cgi?id=272709
rdar://125944789

Reviewed by Chris Dumez.

Adopt `Ref` smart pointer to fix the UAF.

* LayoutTests/fast/css/view-transitions-update-pseudo-element-crash-expected.txt: Added.
* LayoutTests/fast/css/view-transitions-update-pseudo-element-crash.html: Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::setupDynamicStyleSheet):
(WebCore::ViewTransition::updatePseudoElementStyles):

Canonical link: https://commits.webkit.org/277521@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications