[webkit-changes] [WebKit/WebKit] 626da6: [WebGPU] https://playcanvas.github.io/#/misc/spine...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 626da617fd7b0bf6cdefde971c4e594f52e65bf4
      https://github.com/WebKit/WebKit/commit/626da617fd7b0bf6cdefde971c4e594f52e65bf4
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WebGPU] https://playcanvas.github.io/#/misc/spineboy fails because sampler is not compatible with sampler_comparison
https://bugs.webkit.org/show_bug.cgi?id=272599
<rdar://problem/126385846>

Reviewed by Dan Glastonbury.

We are only supposed to validate BindGroupLayout compatibility
with 'statically used' variables in the WGSL source, not all
of the variables which exist.

In this case, PlayCanvas has a mismatch, but they don't use the variable
in the shader, so it shouldn't be a validation error.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):

Canonical link: https://commits.webkit.org/277503@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications