[webkit-changes] [WebKit/WebKit] 907d98: [GTK][WPE] missing URI for injected user scripts a...

Przemyslaw Gorszkowski noreply at github.com
Sun Apr 14 03:26:57 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 907d986d108c64d34ca622b88ec666a5152e5d18
      https://github.com/WebKit/WebKit/commit/907d986d108c64d34ca622b88ec666a5152e5d18
  Author: Przemyslaw Gorszkowski <pgorszkowski at igalia.com>
  Date:   2024-04-14 (Sun, 14 Apr 2024)

  Changed paths:
    M LayoutTests/userscripts/window-onerror-for-isolated-world-1-expected.txt
    M LayoutTests/userscripts/window-onerror-for-isolated-world-2-expected.txt
    M LayoutTests/userscripts/window-onerror-for-isolated-world-3-expected.txt
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/page/UserScript.cpp
    M Source/WebCore/page/UserScript.h
    A Source/WebCore/page/UserStyleSheet.cpp
    M Source/WebCore/page/UserStyleSheet.h
    M Source/WebCore/page/WorkerNavigator.cpp
    M Source/WebKit/UIProcess/API/APIUserScript.cpp
    M Source/WebKit/UIProcess/API/APIUserScript.h
    M Source/WebKit/UIProcess/API/APIUserStyleSheet.cpp
    M Source/WebKit/UIProcess/API/APIUserStyleSheet.h
    M Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKUserScript.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKUserStyleSheet.mm

  Log Message:
  -----------
  [GTK][WPE] missing URI for injected user scripts and style sheets
https://bugs.webkit.org/show_bug.cgi?id=272152

Reviewed by Adrian Perez de Castro.

User scripts/style sheets without the URI are not visible in WebInspector.

With this change the URI of injected user scripts/style sheets are generated as:
user-script:incremented_identifier
user-style:incremented_identifier

* LayoutTests/userscripts/window-onerror-for-isolated-world-1-expected.txt:
* LayoutTests/userscripts/window-onerror-for-isolated-world-2-expected.txt:
* LayoutTests/userscripts/window-onerror-for-isolated-world-3-expected.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/UserScript.cpp: Copied from Source/WebKit/UIProcess/API/APIUserScript.cpp.
(WebCore::generateUniqueURL):
(WebCore::UserScript::UserScript):
* Source/WebCore/page/UserScript.h:
(WebCore::UserScript::UserScript): Deleted.
* Source/WebCore/page/UserStyleSheet.cpp: Copied from Source/WebKit/UIProcess/API/APIUserScript.cpp.
(WebCore::generateUniqueURL):
(WebCore::UserStyleSheet::UserStyleSheet):
* Source/WebCore/page/UserStyleSheet.h:
* Source/WebCore/page/WorkerNavigator.cpp:
* Source/WebKit/UIProcess/API/APIUserScript.cpp:
(API::UserScript::generateUniqueURL): Deleted.
* Source/WebKit/UIProcess/API/APIUserScript.h:
* Source/WebKit/UIProcess/API/APIUserStyleSheet.cpp:
(API::UserStyleSheet::generateUniqueURL): Deleted.
* Source/WebKit/UIProcess/API/APIUserStyleSheet.h:
* Source/WebKit/UIProcess/API/C/WKUserScriptRef.cpp:
(WKUserScriptCreateWithSource):

Canonical link: https://commits.webkit.org/277470@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list