[webkit-changes] [WebKit/WebKit] 39ec95: [WebXR] Don't create WebXRSystem when iterating al...

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39ec95b06fd161d6480b867020ae4339b8f69e5e
      https://github.com/WebKit/WebKit/commit/39ec95b06fd161d6480b867020ae4339b8f69e5e
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2024-04-13 (Sat, 13 Apr 2024)

  Changed paths:
    M Source/WebCore/Modules/webxr/NavigatorWebXR.cpp
    M Source/WebCore/Modules/webxr/NavigatorWebXR.h
    M Source/WebCore/page/Page.cpp

  Log Message:
  -----------
  [WebXR] Don't create WebXRSystem when iterating all DOM objects
https://bugs.webkit.org/show_bug.cgi?id=272564
rdar://124261374

Reviewed by Cameron McCormack.

WebCore::Page::hasActiveImmersiveSession() is creating a new WebXRSystem DOM
object inside WebCore::ScriptExecutionContext::forEachActiveDOMObject(…) which
is forbidden. If there is no WebXRSystem, we should consider that there is no
active immersive session.

* Source/WebCore/Modules/webxr/NavigatorWebXR.cpp:
(WebCore::NavigatorWebXR::xrIfExists):
* Source/WebCore/Modules/webxr/NavigatorWebXR.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::hasActiveImmersiveSession const):

Canonical link: https://commits.webkit.org/277468@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications