[webkit-changes] [WebKit/WebKit] e7b541: MediaPlayerPrivateMediaSourceAVFObjC improperly ch...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7b541d849f77d0541d2092e50348b2f4245ff49
      https://github.com/WebKit/WebKit/commit/e7b541d849f77d0541d2092e50348b2f4245ff49
  Author: Andy Estes <aestes at apple.com>
  Date:   2024-04-13 (Sat, 13 Apr 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

  Log Message:
  -----------
  MediaPlayerPrivateMediaSourceAVFObjC improperly checks m_sampleBufferDisplayLayer to determine if there is a video renderer
https://bugs.webkit.org/show_bug.cgi?id=272608
rdar://126379884

Reviewed by Eric Carlson.

Several places in MediaPlayerPrivateMediaSourceAVFObjC improperly checked for the existence of
m_sampleBufferDisplayLayer to determine if there was a video renderer. This could lead to the video
renderer being torn down unnecessarily or a failure to copy the renderer's displayed pixel buffer.

Addressed this by replacing the uses of m_sampleBufferDisplayLayer with sampleBufferVideoRenderer(),
which returns either m_sampleBufferDisplayLayer or m_sampleBufferVideoRenderer (when rendering to a
video receiver endpoint).

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPresentationSize):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoLayerSizeFenced):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playerContentBoxRectChanged):

Canonical link: https://commits.webkit.org/277459@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications