[webkit-changes] [WebKit/WebKit] d24163: Cherry-pick 277035 at main (fef30aefacf7). https://bu...

[Tim Nguyen]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: d24163a104986bb3b4db2337da67389dd1f822d6
      https://github.com/WebKit/WebKit/commit/d24163a104986bb3b4db2337da67389dd1f822d6
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-04-12 (Fri, 12 Apr 2024)

  Changed paths:
    M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp
    M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h

  Log Message:
  -----------
  Cherry-pick 277035 at main (fef30aefacf7). https://bugs.webkit.org/show_bug.cgi?id=272048

    Thread safety warning: MediaFormatReader m_duration is unprotected by m_parseTracksLock
    rdar://124551630
    https://bugs.webkit.org/show_bug.cgi?id=272048

    Reviewed by Eric Carlson.

    In addition to holding the lock when accessing m_duration, we should also not be handing
    a reference to an internal variable that can be modified off the calling thread.

    * Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
    (WebKit::MediaFormatReader::duration const):
    * Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h:

    Canonical link: https://commits.webkit.org/277035@main

Canonical link: https://commits.webkit.org/274313.131@webkitglib/2.44


  Commit: 8ce83c4bf224122e0062248752a3ed014efc67e5
      https://github.com/WebKit/WebKit/commit/8ce83c4bf224122e0062248752a3ed014efc67e5
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-04-12 (Fri, 12 Apr 2024)

  Changed paths:
    M Source/WebCore/dom/RadioButtonGroups.cpp

  Log Message:
  -----------
  Cherry-pick 277007 at main (1870b119a450). https://bugs.webkit.org/show_bug.cgi?id=272044

    CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::ValidatedFormListedElement::updateValidity
    https://bugs.webkit.org/show_bug.cgi?id=272044
    rdar://117727866

    Reviewed by Ryosuke Niwa.

    It speculatively fixes a bug that RadioButtonGroup::m_members may contain a nullptr WeakRef.

    * Source/WebCore/dom/RadioButtonGroups.cpp:
    (WebCore::RadioButtonGroup::isEmpty const):
    (WebCore::RadioButtonGroup::remove):
    (WebCore::RadioButtonGroup::setNeedsStyleRecalcForAllButtons):
    (WebCore::RadioButtonGroup::updateValidityForAllButtons):

    Canonical link: https://commits.webkit.org/277007@main

Canonical link: https://commits.webkit.org/274313.132@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/5a64bdf6ebd8...8ce83c4bf224

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications