[webkit-changes] [WebKit/WebKit] 759b0e: REGRESSION (275943 at main): Apps using Aspects frame...

Jer Noble noreply at github.com
Thu Apr 11 13:09:53 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 759b0ea6d2cd7e5196e5d2a78931d8a71c144a88
      https://github.com/WebKit/WebKit/commit/759b0ea6d2cd7e5196e5d2a78931d8a71c144a88
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
    M Source/WebKit/UIProcess/ApplicationStateTracker.mm

  Log Message:
  -----------
  REGRESSION (275943 at main): Apps using Aspects framework can crash after ApplicationStateTracker adds KVObserver
https://bugs.webkit.org/show_bug.cgi?id=272532
rdar://125932015

Reviewed by Brent Fulgham.

Aspects.framework will crash if it tries to add a "hook" for KVO after an observer has already
been added to the target object. Add a linked-on-or-after check which disables this KVO, giving
apps time to move off of using Aspects in their production code.

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/UIProcess/ApplicationStateTracker.mm:
(-[WKUIWindowSceneObserver setObservedWindow:]):

Canonical link: https://commits.webkit.org/277396@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list