[webkit-changes] [WebKit/WebKit] 1c7cad: [SVG] We should check firstLineStyle's FontCascade...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c7cadbfcd619e668186d5c35dc2ef38a35bacb3
      https://github.com/WebKit/WebKit/commit/1c7cadbfcd619e668186d5c35dc2ef38a35bacb3
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-04-10 (Wed, 10 Apr 2024)

  Changed paths:
    M LayoutTests/platform/ios/svg/text/scaling-font-with-geometric-precision-expected.txt
    M LayoutTests/platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt
    M Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp

  Log Message:
  -----------
  [SVG] We should check firstLineStyle's FontCascade in SVGTextMetricsBuilder
https://bugs.webkit.org/show_bug.cgi?id=272484
rdar://126232464

Reviewed by Cameron McCormack.

Since SVG is not implementing ::first-line, it keeps FontCascade stale when RenderSVGInlineText gets scaled FontCascade.
As a result, we always go to the slow path in SVGTextMetricsBuilder when RenderSVGInlineText gets scaled font.
We pass `nullptr` now since we do not have support of first-line in SVG text.

* Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):

Canonical link: https://commits.webkit.org/277363@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications