[webkit-changes] [WebKit/WebKit] d41c16: Add data task signposts for _WKDataTask requests

bnham noreply at github.com
Wed Apr 10 17:43:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d41c16dc9131e22004d607de6eb609cc83a1a1d4
      https://github.com/WebKit/WebKit/commit/d41c16dc9131e22004d607de6eb609cc83a1a1d4
  Author: Ben Nham <nham at apple.com>
  Date:   2024-04-10 (Wed, 10 Apr 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/WKURLSessionTaskDelegate.h
    M Source/WebKit/NetworkProcess/cocoa/WKURLSessionTaskDelegate.mm

  Log Message:
  -----------
  Add data task signposts for _WKDataTask requests
https://bugs.webkit.org/show_bug.cgi?id=271075
rdar://124708190

Reviewed by Sihui Liu.

We had some power issues that were harder to diagnose than they should have been because data tasks
created by _WKDataTask (which eventually calls down to NetworkProcess::dataTaskWithRequest) don't
have signposts like other NetworkProcess data tasks. This adds those signposts so future bugs will
be easier to triage.

* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::dataTaskWithRequest):
* Source/WebKit/NetworkProcess/cocoa/WKURLSessionTaskDelegate.h:
* Source/WebKit/NetworkProcess/cocoa/WKURLSessionTaskDelegate.mm:
(-[WKURLSessionTaskDelegate initWithTask:identifier:session:]):
(-[WKURLSessionTaskDelegate dealloc]):
(-[WKURLSessionTaskDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKURLSessionTaskDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKURLSessionTaskDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[WKURLSessionTaskDelegate URLSession:dataTask:didReceiveData:]):
(-[WKURLSessionTaskDelegate URLSession:task:didCompleteWithError:]):
(-[WKURLSessionTaskDelegate initWithIdentifier:session:]): Deleted.

Canonical link: https://commits.webkit.org/277338@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list