[webkit-changes] [WebKit/WebKit] 2e1d51: Allow subclasses of WKWebViewConfiguration again

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e1d510b054f71f8611cce938af3793192e94516
      https://github.com/WebKit/WebKit/commit/2e1d510b054f71f8611cce938af3793192e94516
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm

  Log Message:
  -----------
  Allow subclasses of WKWebViewConfiguration again
https://bugs.webkit.org/show_bug.cgi?id=272406
rdar://125931255

Reviewed by Ben Nham.

In 276566 at main I made WKWebViewConfiguration just a wrapper around API::PageConfiguration
but I also changed the implementation of copyWithZone, which can be implemented and used
by subclasses, to be incompatible with that.  WKWebView already has an ivar for the actual
ObjC WKWebViewConfiguration or subclass.  This small change makes using that once again
possible.

* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
(-[SubclassWebViewConfiguration subclassData]):
(-[SubclassWebViewConfiguration setSubclassData:]):
(-[SubclassWebViewConfiguration copyWithZone:]):
(TEST(WebKit, ConfigurationSubclass)):

Canonical link: https://commits.webkit.org/277262@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications