[webkit-changes] [WebKit/WebKit] b538c7: LinkText and VisitedText system colors doesn't obe...

Luke Warlow noreply at github.com
Tue Apr 9 11:45:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b538c70c4d25f6ed285f69728f78a54cb4b9ad14
      https://github.com/WebKit/WebKit/commit/b538c70c4d25f6ed285f69728f78a54cb4b9ad14
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
    M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/mac/RenderThemeMac.mm

  Log Message:
  -----------
  LinkText and VisitedText system colors doesn't obey color scheme
https://bugs.webkit.org/show_bug.cgi?id=272299

Reviewed by Tim Nguyen.

Change LinkText and VisitedText CSS system colors to use a different value when the used color scheme is dark.
The chosen colors are the same as `-webkit-link` and are what is expected by WPT tests.

* LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor const):
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const):

Canonical link: https://commits.webkit.org/277259@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list