[webkit-changes] [WebKit/WebKit] c5b0e4: [WGSL] Fix broken wgslc tests

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5b0e434b552f9ea9b45b699beeeea435b1bd048
      https://github.com/WebKit/WebKit/commit/c5b0e434b552f9ea9b45b699beeeea435b1bd048
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-04-08 (Mon, 08 Apr 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    A Source/WebGPU/WGSL/tests/invalid/attribute-validation-during-type-checking.wgsl
    M Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl
    M Source/WebGPU/WGSL/tests/valid/concretization.wgsl
    M Source/WebGPU/WGSL/tests/valid/constants-utf16.wgsl
    M Source/WebGPU/WGSL/tests/valid/constants.wgsl
    M Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl
    M Source/WebGPU/WGSL/tests/valid/packing.wgsl

  Log Message:
  -----------
  [WGSL] Fix broken wgslc tests
https://bugs.webkit.org/show_bug.cgi?id=272227
rdar://125966589

Reviewed by Mike Wyrzykowski and Dan Glastonbury.

The tests just needed to be updated because they contained invalid code that
is now being rejected after we added more validation.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* Source/WebGPU/WGSL/tests/invalid/attribute-validation-during-type-checking.wgsl: Added.
* Source/WebGPU/WGSL/tests/invalid/attribute-validation.wgsl:
* Source/WebGPU/WGSL/tests/valid/concretization.wgsl:
* Source/WebGPU/WGSL/tests/valid/constants-utf16.wgsl:
* Source/WebGPU/WGSL/tests/valid/constants.wgsl:
* Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:

Canonical link: https://commits.webkit.org/277194@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications