[webkit-changes] [WebKit/WebKit] 312e6e: [JSC] Emit op_get_length in @arrayPush()

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 312e6efc4b6f6675c5ccdaa9e6a346f1cbdcdd85
      https://github.com/WebKit/WebKit/commit/312e6efc4b6f6675c5ccdaa9e6a346f1cbdcdd85
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2024-04-07 (Sun, 07 Apr 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
    M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h
    M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

  Log Message:
  -----------
  [JSC] Emit op_get_length in @arrayPush()
https://bugs.webkit.org/show_bug.cgi?id=236424
<rdar://problem/89062176>

Reviewed by Yusuke Suzuki.

This change slightly optimizes @arrayPush() intrinsic by leveraging newly-introduced bytecode op
to retrieve "length" rather than more generic op_get_by_id.

No new tests, no behavior change.

* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetLength):
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_arrayPush):

Canonical link: https://commits.webkit.org/277179@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications