[webkit-changes] [WebKit/WebKit] f13b4f: [WebGPU] rename writeBuffer which takes a non-cons...

mwyrzykowski noreply at github.com
Fri Apr 5 20:07:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f13b4f7f2205531e7c68e4e03d854ae82acf43a6
      https://github.com/WebKit/WebKit/commit/f13b4f7f2205531e7c68e4e03d854ae82acf43a6
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-04-05 (Fri, 05 Apr 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h

  Log Message:
  -----------
  [WebGPU] rename writeBuffer which takes a non-const data to writeBufferNoCopy
https://bugs.webkit.org/show_bug.cgi?id=272160
<radar://125913199>

Reviewed by Chris Dumez.

We shouldn’t have overloaded a method on the constness of a pointer, that is fragile, just give it a different name.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp:
(WebCore::WebGPU::QueueImpl::writeBufferNoCopy):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp:
(WebKit::RemoteQueue::writeBuffer):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp:
(WebKit::WebGPU::RemoteQueueProxy::writeBufferNoCopy):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h:

Canonical link: https://commits.webkit.org/277146@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list