[webkit-changes] [WebKit/WebKit] fa54f7: Make _WKApplicationManifest initializer return nil...

Sihui noreply at github.com
Thu Apr 4 23:38:54 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa54f7ce3cd9b71732786437b9d5dcde72a4c07f
      https://github.com/WebKit/WebKit/commit/fa54f7ce3cd9b71732786437b9d5dcde72a4c07f
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-04-04 (Thu, 04 Apr 2024)

  Changed paths:
    M Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp
    M Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm

  Log Message:
  -----------
  Make _WKApplicationManifest initializer return nil when jsonData is not valid JSON
https://bugs.webkit.org/show_bug.cgi?id=272161
rdar://125913241

Reviewed by Chris Dumez.

API Test: WKApplicationManifest.InvalidJSONData

* Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:
(WebCore::ApplicationManifestParser::parse):
(WebCore::ApplicationManifestParser::parseWithValidation):
(WebCore::ApplicationManifestParser::createJSONObject):
(WebCore::ApplicationManifestParser::parseManifest):
* Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:
(-[_WKApplicationManifest initWithJSONData:manifestURL:documentURL:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:
(TestWebKitAPI::TEST(WKApplicationManifest, InvalidJSONData)):

Canonical link: https://commits.webkit.org/277098@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list