[webkit-changes] [WebKit/WebKit] f3925d: Some API tests started crashing in CFRelease after...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3925d705c14b41a1722888fd11619e5ab1779ba
      https://github.com/WebKit/WebKit/commit/f3925d705c14b41a1722888fd11619e5ab1779ba
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm

  Log Message:
  -----------
  Some API tests started crashing in CFRelease after macOS update
https://bugs.webkit.org/show_bug.cgi?id=272110
rdar://125807895

Reviewed by Brady Eidson and Sihui Liu.

Our API test was unsafe as it was not ref'ing autoreleased
NSStrings / NSURLs and expecting them to still be alive after
calling some async operations.

Update those tests to use RetainPtr more consistently.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm:
(TEST(IndexedDB, CheckpointsWALAutomatically)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
(runMultipleIndicesTestWithDatabase):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
(IndexedDBThirdPartyStorageLayout)):
((IndexedDB, IndexedDBGetDatabases)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
(TEST(IndexedDB, IndexedDBTempFileSize)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
(TEST(IndexedDB, StoreBlobThenRemoveData)):
(TEST(IndexedDB, StoreBlobThenDeleteDatabase)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
((WKWebsiteDataStore, RemoveServiceWorkerData)):

Canonical link: https://commits.webkit.org/277042@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications