[webkit-changes] [WebKit/WebKit] fef30a: Thread safety warning: MediaFormatReader m_duratio...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fef30aefacf72c9c0cb3ce0a2d84fd3bd7fbf4b7
      https://github.com/WebKit/WebKit/commit/fef30aefacf72c9c0cb3ce0a2d84fd3bd7fbf4b7
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp
    M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h

  Log Message:
  -----------
  Thread safety warning: MediaFormatReader m_duration is unprotected by m_parseTracksLock
rdar://124551630
https://bugs.webkit.org/show_bug.cgi?id=272048

Reviewed by Eric Carlson.

In addition to holding the lock when accessing m_duration, we should also not be handing
a reference to an internal variable that can be modified off the calling thread.

* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::duration const):
* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h:

Canonical link: https://commits.webkit.org/277035@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications