[webkit-changes] [WebKit/WebKit] 4754c8: REGRESSION (275949 at main): 18 imported WPT /i18n/.....

Alan Baradlay noreply at github.com
Wed Apr 3 14:37:39 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4754c8d81df8cfe4e842b7aa4d1173b3bc59f5be
      https://github.com/WebKit/WebKit/commit/4754c8d81df8cfe4e842b7aa4d1173b3bc59f5be
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.h
    M Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionContext.h

  Log Message:
  -----------
  REGRESSION (275949 at main): 18 imported WPT /i18n/.../css-text-line-break* tests are consistent/flaky failures.
https://bugs.webkit.org/show_bug.cgi?id=270860
<rdar://problem/124463423>

Reviewed by Antti Koivisto.

Same content with different locale may produce different soft wrap opportunities. Let's include computedLocal in the key.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.cpp:
(WebCore::Layout::add):
* Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.h:
* Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionContext.h:
(WebCore::Layout::TextBreakingPositionContext::TextBreakingPositionContext):

Canonical link: https://commits.webkit.org/277033@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list