[webkit-changes] [WebKit/WebKit] 256947: [Navigation] Process NavigateEvent earlier in Fram...

Rob Buis noreply at github.com
Wed Apr 3 14:15:24 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25694764feddef056fca34e4757708ef5cd45503
      https://github.com/WebKit/WebKit/commit/25694764feddef056fca34e4757708ef5cd45503
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment-expected.txt
    M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  -----------
  [Navigation] Process NavigateEvent earlier in FrameLoader::loadInSameDocument
https://bugs.webkit.org/show_bug.cgi?id=271464

Reviewed by Alex Christensen.

Process NavigateEvent earlier in FrameLoader::loadInSameDocument, this allows us to properly determine same document
and hashChange values, before updating the document url. Also now we react to preventDefault() calls by doing an early return.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):

Canonical link: https://commits.webkit.org/277030@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list