[webkit-changes] [WebKit/WebKit] 38f64d: ASSERTION FAILED (!m_inStyleRecalc) in Document::u...

Alan Baradlay noreply at github.com
Wed Apr 3 08:13:30 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38f64dda7344e7b24a0efe0da543e80060e12b8c
      https://github.com/WebKit/WebKit/commit/38f64dda7344e7b24a0efe0da543e80060e12b8c
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/Node.h
    M Source/WebCore/page/ios/ContentChangeObserver.cpp

  Log Message:
  -----------
  ASSERTION FAILED (!m_inStyleRecalc) in Document::usesStyleBasedEditability() when inline media controls are presented
https://bugs.webkit.org/show_bug.cgi?id=271972
<rdar://125502350>

Reviewed by Antti Koivisto.

ContentChangeObserver::isConsideredActionableContent is called when we finished updating the element (see RenderTreeUpdater::updateElementRenderer)
meaning computed style (including descendants) should be all up-to-date.

* Source/WebCore/dom/Node.cpp:
(WebCore::Node::willRespondToMouseClickEvents const):
* Source/WebCore/dom/Node.h:
* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::isConsideredActionableContent const):

Canonical link: https://commits.webkit.org/277000@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list