[webkit-changes] [WebKit/WebKit] b78e11: [@starting-style] Style adjuster wrongly invoked w...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b78e11bab3e30ab21cd2847a963341825126c1ee
      https://github.com/WebKit/WebKit/commit/b78e11bab3e30ab21cd2847a963341825126c1ee
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment.html
    M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  -----------
  [@starting-style] Style adjuster wrongly invoked with null element
https://bugs.webkit.org/show_bug.cgi?id=272076
rdar://125837628

Reviewed by Antoine Quint.

We may compute wrong starting style for elements that require style adjustments. This may have observable effects.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment.html: Added.

<legend> is always blockified per HTML spec. Test we don't trigger a transition based on before-adjustment value.

* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveStartingStyle const):

The pseudo-element logic was reversed.

Canonical link: https://commits.webkit.org/276993@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications