[webkit-changes] [WebKit/WebKit] 45567b: Cherry-pick 276856.1 at bugfix/angle_fix_is_always_lo...

Charlie Lao noreply at github.com
Tue Apr 2 12:04:01 PDT 2024


  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 45567b5403c1820b674654a4470b7d075aa79ba3
      https://github.com/WebKit/WebKit/commit/45567b5403c1820b674654a4470b7d075aa79ba3
  Author: Charlie Lao <cclao at google.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/serial_utils.h

  Log Message:
  -----------
  Cherry-pick 276856.1 at bugfix/angle_fix_is_always_lock_free (4399714e71df). https://bugs.webkit.org/show_bug.cgi?id=252670

[ANGLE]: fix is_always_lock_free assertion on 32 bit arch

https://bugs.webkit.org/show_bug.cgi?id=252670

Reviewed by NOBODY (OOPS!).

Remove is_always_lock_free assertion from AtomicQueueSerial

Build will fail when compiled on 32 bit architecture. The code will
still function on 32 bit architecture but with performance penalty due
to lock. But we are not really expecting it actually run on 32 bit
platform with vulkan backend (the atomic queue serial is only used by
vulkan backend). We could move AtomicQueueSerial into vulkan backend,
but that will be a much larger change that I try to avoid. This CL
removes the static_assertion and make it 8 bytes aligned as well.

Bug: angleproject:7989
Change-Id: I3c0bd9877c4171485ca1aa9af0cf4621c1c23f56
Reviewed-on:
https://chromium-review.googlesource.com/c/angle/angle/+/5407870
Reviewed-by: Shahbaz Youssefi <syoussefi at chromium.org>
Commit-Queue: Charlie Lao <cclao at google.com>

Upstream:
https://chromium.googlesource.com/angle/angle/+/321c6b63bebce3f31414d8a53fb2f94b5561b818
Signed-off-by: Thomas Devoogdt <thomas at devoogdt.com>



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list