[webkit-changes] [WebKit/WebKit] fd49ec: Make default safety of align-content on block cont...

fantasai noreply at github.com
Tue Apr 2 01:09:34 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd49ec9a304465a0e383ecd001823c9cc354cb38
      https://github.com/WebKit/WebKit/commit/fd49ec9a304465a0e383ecd001823c9cc354cb38
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-block-overflow-000-expected.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-block-overflow-000-ref.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-block-001.html
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  Make default safety of align-content on block containers that are scroll containers unsafe.
https://bugs.webkit.org/show_bug.cgi?id=272002
rdar://problem/125742095

Reviewed by Simon Fraser.

Tweaks the align-content safety checks for RenderBlockFlow to assume
"unsafe" rather than "safe" alignment on scroll containers.

* LayoutTests/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-block-overflow-000-expected.html: Adjust expectations.
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-block-overflow-000-ref.html: Adjust expectations.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-block-001.html: Adjust expectations.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::shiftForAlignContent): Check for 'safe' and content distribution explicitly, limit default safety check to non-scroll-containers.
(WebCore::RenderBlockFlow::allowedLayoutOverflow const): Simplify short-circuit alignment check.

Canonical link: https://commits.webkit.org/276929@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list