[webkit-changes] [WebKit/WebKit] 59cedf: Linker error when logging ViewportConfiguration to...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59cedf7135bc81ea30a89477356dfd5951764d2d
      https://github.com/WebKit/WebKit/commit/59cedf7135bc81ea30a89477356dfd5951764d2d
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-04-01 (Mon, 01 Apr 2024)

  Changed paths:
    M Source/WebCore/page/ViewportConfiguration.cpp
    M Source/WebCore/page/ViewportConfiguration.h

  Log Message:
  -----------
  Linker error when logging ViewportConfiguration to TextStream in Release configuration
https://bugs.webkit.org/show_bug.cgi?id=271962
rdar://125713559

Reviewed by Sihui Liu.

WebCore::operator<<(WTF::TextStream&, WebCore::ViewConfiguration const&)
is defined behind !LOG_DISABLED, which means in Release configuration,
the linker cannot find this definition.

This patch fixes the linker error by removing the relevant !LOG_DISABLED
checks around both the operator<< overload definition and the
description()/dump() declarations, since said methods are referenced by
the operator<< overload.

* Source/WebCore/page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setIsKnownToLayOutWiderThanViewport):
(WebCore::ViewportConfiguration::dump const):
* Source/WebCore/page/ViewportConfiguration.h:

Canonical link: https://commits.webkit.org/276925@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications