[webkit-changes] [WebKit/WebKit] 442e56: Security key doesn't show up when allowCredentials...

Commit Queue noreply at github.com
Mon Apr 1 12:55:16 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 442e5675cbb3f411a08db3c8bc4b9ed0afdfb95a
      https://github.com/WebKit/WebKit/commit/442e5675cbb3f411a08db3c8bc4b9ed0afdfb95a
  Author: Pascoe <pascoe at apple.com>
  Date:   2024-04-01 (Mon, 01 Apr 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

  Log Message:
  -----------
  Security key doesn't show up when allowCredentials transports contain "Internal"
https://bugs.webkit.org/show_bug.cgi?id=271805
rdar://124265507

Reviewed by Brent Fulgham.

This condition was written wrong. We should submit a cross-platform request if transports are empty, or if
they contain any transport that is not "Internal" or "Hybrid," which are both considered platform requests
by system API.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::WebAuthenticatorCoordinatorProxy::requestsForAssertion):

Canonical link: https://commits.webkit.org/276894@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list