[webkit-changes] [WebKit/WebKit] 13274c: Skip non-text svg elements in Position [upstream |...

Ahmad Saleem noreply at github.com
Sat Sep 30 19:02:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13274cf68d90652bf43b4b3205403b2d9d78a6d6
      https://github.com/WebKit/WebKit/commit/13274cf68d90652bf43b4b3205403b2d9d78a6d6
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-09-30 (Sat, 30 Sep 2023)

  Changed paths:
    M Source/WebCore/dom/Position.cpp

  Log Message:
  -----------
  Skip non-text svg elements in Position [upstream | downstream]

https://bugs.webkit.org/show_bug.cgi?id=261984
rdar://problem/116261189

Reviewed by Ryosuke Niwa and Wenson Hsieh.

Merge: https://chromium.googlesource.com/chromium/src.git/+/8e793a18ec6358414ffc337b336c93d4f6061c91

There is no caret position in non-text svg elements. Hence, this patch
skips such elements in the two functions for performance optimization.

Manually tested on test case from the bug and noticed that the local build
with patch is performing significantly better.

* Source/WebCore/dom/Position.cpp:
(Position::upstream):
(Position::downstream):

Canonical link: https://commits.webkit.org/268699@main




More information about the webkit-changes mailing list