[webkit-changes] [WebKit/WebKit] 13307f: AX: accessibility/video-element-url-attribute.html...

Tyler Wilcock noreply at github.com
Fri Sep 29 12:18:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13307fb298e4d06b8d29d12668b44571818103b2
      https://github.com/WebKit/WebKit/commit/13307fb298e4d06b8d29d12668b44571818103b2
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/accessibility/video-element-url-attribute-expected.txt
    M LayoutTests/accessibility/video-element-url-attribute.html

  Log Message:
  -----------
  AX: accessibility/video-element-url-attribute.html is a flakey timeout
https://bugs.webkit.org/show_bug.cgi?id=262355
rdar://problem/116219239

Reviewed by Chris Fleizach.

Seems like the readyState DOM API is flakey in layout tests, so switch
to the accessibility-helper.js expectAsync function. We need to use
expectAsync to wait asynchronously for the video to load in order to return
the correct URL (which is what the readyState check tried to do before).

* LayoutTests/TestExpectations: Remove timeout expectation.
* LayoutTests/accessibility/video-element-url-attribute-expected.txt:
* LayoutTests/accessibility/video-element-url-attribute.html:
Re-write test.

Canonical link: https://commits.webkit.org/268663@main




More information about the webkit-changes mailing list