[webkit-changes] [WebKit/WebKit] c879b9: MediaPlayerPrivateAVFoundationObjC::paintWithImage...

Kimmo Kinnunen noreply at github.com
Fri Sep 29 07:03:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c879b942c9a21906b12b0de5edc1805cbe9eafe1
      https://github.com/WebKit/WebKit/commit/c879b942c9a21906b12b0de5edc1805cbe9eafe1
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

  Log Message:
  -----------
  MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator is an unused function
https://bugs.webkit.org/show_bug.cgi?id=262363
rdar://116231020

Reviewed by Youenn Fablet.

Remove the unused function.

The function is bad because it sets up GraphicsContext state but then
uses CG to draw a CGImage.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Deleted.

Canonical link: https://commits.webkit.org/268648@main




More information about the webkit-changes mailing list