[webkit-changes] [WebKit/WebKit] 81ab06: Implement keyboard events for site isolation

Charlie Wolfe noreply at github.com
Fri Sep 29 01:32:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81ab068d217bd79ff4f6e841dfb8e7a854684ade
      https://github.com/WebKit/WebKit/commit/81ab068d217bd79ff4f6e841dfb8e7a854684ade
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/key-events-expected.txt
    A LayoutTests/http/tests/site-isolation/key-events.html
    A LayoutTests/http/tests/site-isolation/resources/key-event-handler.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp

  Log Message:
  -----------
  Implement keyboard events for site isolation
https://bugs.webkit.org/show_bug.cgi?id=262286
rdar://116167166

Reviewed by Alex Christensen.

Currently, key events rely on `FocusController` in the web process to determine which frame should receive
a key event. For site isolation, we should reference information on the focused frame stored in the UI
process so we can send the key event directly to the web process hosting the focused frame.

EventSenderProxyIOS::keyDown() is not implemented, so disable the test on iOS.

* LayoutTests/http/tests/site-isolation/key-events-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/key-events.html: Added.
* LayoutTests/http/tests/site-isolation/resources/key-event-handler.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendKeyEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::handleKeyEvent):

Canonical link: https://commits.webkit.org/268639@main




More information about the webkit-changes mailing list