[webkit-changes] [WebKit/WebKit] b0eaec: [WK2] Extension targets' SUPPORTED_PLATFORMS setti...

Elliott Williams noreply at github.com
Thu Sep 28 19:06:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0eaecf6d9e13180ae2b627c84b0a5a44427c21c
      https://github.com/WebKit/WebKit/commit/b0eaecf6d9e13180ae2b627c84b0a5a44427c21c
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M Source/WebKit/Configurations/BaseExtension.xcconfig

  Log Message:
  -----------
  [WK2] Extension targets' SUPPORTED_PLATFORMS setting uses quotes; Xcode does not parse it as a string list
https://bugs.webkit.org/show_bug.cgi?id=262348
rdar://116210374

Unreviewed build fix.

It's leading to issues like:

    warning: Did not find any platform for SUPPORTED_PLATFORMS 'appletvos appletvsimulator iphoneos iphonesimulator macosx watchos

and, in IDE builds (where we aren't using Make to set SDKROOT), appears
to be causing the appex targets to build against the macOS SDK.

Also fix quoting around TARGETED_DEVICE_FAMILY, which is emitting issues
like:

    warning: unexpected TARGETED_DEVICE_FAMILY item: `"1`
    warning: unexpected TARGETED_DEVICE_FAMILY item: `2"`

* Source/WebKit/Configurations/BaseExtension.xcconfig:

Canonical link: https://commits.webkit.org/268624@main




More information about the webkit-changes mailing list