[webkit-changes] [WebKit/WebKit] c16ca1: REGRESSION(268480 at main): test/language/arguments-o...

Commit Queue noreply at github.com
Thu Sep 28 11:52:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c16ca1954e5c440176429e8beac18895637eed0b
      https://github.com/WebKit/WebKit/commit/c16ca1954e5c440176429e8beac18895637eed0b
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M JSTests/stress/get-arguments-length-fast.js
    M Source/JavaScriptCore/parser/ASTBuilder.h

  Log Message:
  -----------
  REGRESSION(268480 at main): test/language/arguments-object/S10.6_A5_T3.js test262 test is failing
https://bugs.webkit.org/show_bug.cgi?id=262315
rdar://116187196

Reviewed by Yusuke Suzuki.

Previously, we introduced a fast path for getting `arguments.length`
by retrieving `argumentCountIncludingThis` from CallFrame (268480 at main).
However, we should disable the fast path when `delete arguments.length`
since it modifies `arguments`.

* JSTests/stress/get-arguments-length-fast.js:
(deleteArgumentsLength):
* Source/JavaScriptCore/parser/ASTBuilder.h:
(JSC::ASTBuilder::makeDeleteNode):

Canonical link: https://commits.webkit.org/268601@main




More information about the webkit-changes mailing list