[webkit-changes] [WebKit/WebKit] 28e1c2: [IFC][Ruby] Check base content overlap for annotat...

Alan Baradlay noreply at github.com
Thu Sep 28 06:43:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28e1c28b6e379f9789172e275bc0b1ac51baf851
      https://github.com/WebKit/WebKit/commit/28e1c28b6e379f9789172e275bc0b1ac51baf851
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  -----------
  [IFC][Ruby] Check base content overlap for annotation overhang
https://bugs.webkit.org/show_bug.cgi?id=262237

Reviewed by Antti Koivisto.

Check how much space there is between the base content and the neighboring runs and
use it as a "fallback" value when we can't overhang the annotation all the way to "half of a full width character" (this is to prevent base content and adjacent inline content from getting overlapped).

* Source/WTF/wtf/CheckedRef.h:
(WTF::CanMakeCheckedPtrBase::~CanMakeCheckedPtrBase):
(WTF::CanMakeCheckedPtrBase::decrementPtrCount const):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang const):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationBefore):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationAfter):
(WebCore::Layout::RubyFormattingContext::annotationOverlapCheck const):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/268581@main




More information about the webkit-changes mailing list