[webkit-changes] [WebKit/WebKit] 41370a: [WGSL] Add type declarations for functions that op...

Tadeu Zagallo noreply at github.com
Thu Sep 28 01:31:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41370a1f61a5212398a31bc6d625b292fa342bb5
      https://github.com/WebKit/WebKit/commit/41370a1f61a5212398a31bc6d625b292fa342bb5
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-09-28 (Thu, 28 Sep 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/Overload.cpp
    M Source/WebGPU/WGSL/Overload.h
    M Source/WebGPU/WGSL/TypeDeclarations.rb
    M Source/WebGPU/WGSL/Types.cpp
    M Source/WebGPU/WGSL/Types.h
    M Source/WebGPU/WGSL/generator/main.rb
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl

  Log Message:
  -----------
  [WGSL] Add type declarations for functions that operate on texture_storage
https://bugs.webkit.org/show_bug.cgi?id=262202
rdar://116133188

Reviewed by Mike Wyrzykowski.

When I added all the type declarations for the texture built-in functions, we didn't
support texture_storage yet. This patch adds support for texture storage in the
overload resolution and adds the missing declarations.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Overload.cpp:
(WGSL::OverloadResolver::materialize const):
(WGSL::OverloadResolver::calculateRank):
(WGSL::OverloadResolver::unify):
(WTF::printInternal):
* Source/WebGPU/WGSL/Overload.h:
* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::shaderTypeForTexelFormat):
* Source/WebGPU/WGSL/Types.h:
* Source/WebGPU/WGSL/generator/main.rb:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/268572@main




More information about the webkit-changes mailing list