[webkit-changes] [WebKit/WebKit] ec52f0: [JSC][armv7] Small fixes for DataIC address comput...

jjgriego noreply at github.com
Wed Sep 27 18:15:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec52f0d00cbd1a7387bcd768bcd9377b8f454a33
      https://github.com/WebKit/WebKit/commit/ec52f0d00cbd1a7387bcd768bcd9377b8f454a33
  Author: Joseph Griego <jgriego at igalia.com>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp

  Log Message:
  -----------
  [JSC][armv7] Small fixes for DataIC address computations
https://bugs.webkit.org/show_bug.cgi?id=262132

Reviewed by Yusuke Suzuki.

Fixes a great deal of the test suite.

`push {r7, lr}` uses 4 bytes, so the prologue size needs to be 6 and not 4.

Also, CodePtr::untaggedPtr produces a pointer suitable for jmp/call targets,
which for thumb code is off by 1--use `dataLocation()` instead for doing pointer
arithmetic--this change should affect nothing on other architectures.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::regenerate):

Canonical link: https://commits.webkit.org/268555@main




More information about the webkit-changes mailing list