[webkit-changes] [WebKit/WebKit] 3b05ce: Use more smart pointers in editing code

Chris Dumez noreply at github.com
Wed Sep 27 17:01:55 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b05ce368eccb0c5c42dbdeb17e541e6418fbef8
      https://github.com/WebKit/WebKit/commit/3b05ce368eccb0c5c42dbdeb17e541e6418fbef8
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M Source/WebCore/dom/Position.cpp
    M Source/WebCore/dom/Position.h
    M Source/WebCore/editing/AlternativeTextController.cpp
    M Source/WebCore/editing/AlternativeTextController.h
    M Source/WebCore/editing/AppendNodeCommand.cpp
    M Source/WebCore/editing/AppendNodeCommand.h
    M Source/WebCore/editing/ApplyBlockElementCommand.cpp
    M Source/WebCore/editing/ApplyStyleCommand.cpp
    M Source/WebCore/editing/BreakBlockquoteCommand.cpp
    M Source/WebCore/editing/CompositeEditCommand.cpp
    M Source/WebCore/editing/CompositeEditCommand.h
    M Source/WebCore/editing/CreateLinkCommand.cpp
    M Source/WebCore/editing/CustomUndoStep.cpp
    M Source/WebCore/editing/DeleteFromTextNodeCommand.cpp
    M Source/WebCore/editing/DeleteFromTextNodeCommand.h
    M Source/WebCore/editing/DeleteSelectionCommand.cpp
    M Source/WebCore/editing/DeleteSelectionCommand.h
    M Source/WebCore/editing/DictationCommand.cpp
    M Source/WebCore/editing/DictationCommand.h
    M Source/WebCore/editing/EditCommand.cpp
    M Source/WebCore/editing/EditCommand.h
    M Source/WebCore/editing/Editing.cpp
    M Source/WebCore/editing/Editing.h
    M Source/WebCore/editing/InsertListCommand.cpp
    M Source/WebCore/editing/InsertListCommand.h
    M Source/WebCore/editing/TypingCommand.cpp
    M Source/WebCore/editing/VisibleSelection.cpp
    M Source/WebCore/page/AlternativeTextClient.h
    M Source/WebCore/page/DragController.cpp
    M Source/WebCore/page/EditorClient.h

  Log Message:
  -----------
  Use more smart pointers in editing code
https://bugs.webkit.org/show_bug.cgi?id=262200

Reviewed by Brent Fulgham.

* Source/WebCore/dom/Position.cpp:
(WebCore::Position::protectedContainerText const):
* Source/WebCore/dom/Position.h:
* Source/WebCore/editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::startAlternativeTextUITimer):
(WebCore::AlternativeTextController::stopPendingCorrection):
(WebCore::AlternativeTextController::isSpellingMarkerAllowed const):
(WebCore::AlternativeTextController::show):
(WebCore::AlternativeTextController::dismiss):
(WebCore::AlternativeTextController::dismissSoon):
(WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
(WebCore::AlternativeTextController::timerFired):
(WebCore::AlternativeTextController::handleAlternativeTextUIResult):
(WebCore::AlternativeTextController::canEnableAutomaticSpellingCorrection const):
(WebCore::AlternativeTextController::rootViewRectForRange const):
(WebCore::AlternativeTextController::respondToChangedSelection):
(WebCore::AlternativeTextController::editorClient):
(WebCore::AlternativeTextController::textChecker):
(WebCore::AlternativeTextController::recordAutocorrectionResponse):
(WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::alternativeTextClient):
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
(WebCore::AlternativeTextController::removeCorrectionIndicatorMarkers):
(WebCore::AlternativeTextController::insertDictatedText):
(WebCore::AlternativeTextController::removeDictationAlternativesForMarker):
(WebCore::AlternativeTextController::dictationAlternativesForMarker):
(WebCore::AlternativeTextController::applyDictationAlternative):
* Source/WebCore/editing/AlternativeTextController.h:
(WebCore::AlternativeTextController::protectedDocument const):
* Source/WebCore/editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):
* Source/WebCore/editing/AppendNodeCommand.h:
(WebCore::AppendNodeCommand::protectedParent const):
(WebCore::AppendNodeCommand::protectedNode const):
* Source/WebCore/editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
(WebCore::ApplyBlockElementCommand::formatSelection):
(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::renderStyleOfEnclosingTextNode):
(WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
(WebCore::ApplyBlockElementCommand::endOfNextParagraphSplittingTextNodesIfNeeded):
(WebCore::ApplyBlockElementCommand::createBlockElement):
* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::applyInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::nodeFullySelected const):
(WebCore::ApplyStyleCommand::nodeFullyUnselected const):
(WebCore::ApplyStyleCommand::splitTextAtStart):
(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtStart):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode):
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
(WebCore::ApplyStyleCommand::joinChildTextNodes):
* Source/WebCore/editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::willApplyCommand):
(WebCore::CompositeEditCommand::didApplyCommand):
(WebCore::CompositeEditCommand::composition const):
(WebCore::CompositeEditCommand::ensureComposition):
(WebCore::CompositeEditCommand::isRemovableBlock):
(WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes):
(WebCore::CompositeEditCommand::textNodeForRebalance const):
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
(WebCore::CompositeEditCommand::replaceCollapsibleWhitespaceWithNonBreakingSpaceIfNeeded):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
(WebCore::CompositeEditCommand::removePlaceholderAt):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
(WebCore::CompositeEditCommand::moveParagraphWithClones):
(WebCore::CompositeEditCommand::moveParagraphs):
* Source/WebCore/editing/CompositeEditCommand.h:
(WebCore::EditCommandComposition::protectedDocument const):
* Source/WebCore/editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply):
* Source/WebCore/editing/CustomUndoStep.cpp:
(WebCore::CustomUndoStep::didRemoveFromUndoManager):
* Source/WebCore/editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):
(WebCore::DeleteFromTextNodeCommand::getNodesInCommand):
(WebCore::DeleteFromTextNodeCommand::protectedNode const):
* Source/WebCore/editing/DeleteFromTextNodeCommand.h:
* Source/WebCore/editing/DeleteSelectionCommand.cpp:
(WebCore::isSpecialHTMLElement):
(WebCore::positionBeforeContainingSpecialElement):
(WebCore::positionAfterContainingSpecialElement):
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
(WebCore::DeleteSelectionCommand::insertBlockPlaceholderForTableCellIfNeeded):
(WebCore::DeleteSelectionCommand::removeNodeUpdatingStates):
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::fixupWhitespace):
(WebCore::DeleteSelectionCommand::mergeParagraphs):
(WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
(WebCore::DeleteSelectionCommand::doApply):
* Source/WebCore/editing/DeleteSelectionCommand.h:
(WebCore::DeleteSelectionCommand::protectedStartBlock const):
(WebCore::DeleteSelectionCommand::protectedEndBlock const):
(WebCore::DeleteSelectionCommand::protectedEndTableRow const):
* Source/WebCore/editing/DictationCommand.cpp:
(WebCore::DictationCommandLineOperation::DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::operator() const):
(WebCore::DictationMarkerSupplier::create):
(WebCore::DictationMarkerSupplier::DictationMarkerSupplier):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::doApply):
(WebCore::DictationCommand::insertTextRunWithoutNewlines):
* Source/WebCore/editing/DictationCommand.h:
* Source/WebCore/editing/EditCommand.cpp:
(WebCore::EditCommand::setParent):
(WebCore::EditCommand::postTextStateChangeNotification):
(WebCore::SimpleEditCommand::addNodeAndDescendants):
* Source/WebCore/editing/EditCommand.h:
* Source/WebCore/editing/Editing.cpp:
(WebCore::isEditablePosition):
(WebCore::isRichlyEditablePosition):
(WebCore::editableRootForPosition):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousVisuallyDistinctCandidate):
(WebCore::firstEditablePositionAfterPositionInRoot):
(WebCore::lastEditablePositionBeforePositionInRoot):
(WebCore::isFirstPositionAfterTable):
(WebCore::isLastPositionBeforeTable):
(WebCore::closestEditablePositionInElementForAbsolutePoint):
(WebCore::highestEnclosingNodeOfType):
(WebCore::hasARenderedDescendant):
(WebCore::highestNodeToRemoveInPruning):
(WebCore::enclosingAnchorElement):
(WebCore::enclosingList):
(WebCore::enclosingListChild):
(WebCore::enclosingEmptyListItem):
(WebCore::outermostEnclosingList):
(WebCore::canMergeLists):
(WebCore::nextNodeConsideringAtomicNodes):
(WebCore::isEmptyTableCell):
(WebCore::selectionForParagraphIteration):
(WebCore::indexForVisiblePosition):
(WebCore::localCaretRectInRendererForRect):
(WebCore::visibleImageElementsInRangeWithNonLoadedImages):
* Source/WebCore/editing/Editing.h:
* Source/WebCore/editing/InsertListCommand.cpp:
(WebCore::enclosingListChild):
(WebCore::InsertListCommand::selectionHasListOfType):
(WebCore::InsertListCommand::doApplyForSingleParagraph):
(WebCore::adjacentEnclosingList):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed):
* Source/WebCore/editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionRespectingGranularity):
* Source/WebCore/page/AlternativeTextClient.h:
* Source/WebCore/page/DragController.cpp:
(WebCore::DragController::startDrag):
* Source/WebCore/page/EditorClient.h:

Canonical link: https://commits.webkit.org/268548@main

More information about the webkit-changes mailing list