[webkit-changes] [WebKit/WebKit] 824b10: _WKHitTestResult should expose an elementType prop...

[Jeff Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 824b10f0e852a126afc79ec2093271a5eca869b6
      https://github.com/WebKit/WebKit/commit/824b10f0e852a126afc79ec2093271a5eca869b6
  Author: Jeff Miller <jeffm at apple.com>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M Source/WebCore/rendering/HitTestResult.cpp
    M Source/WebCore/rendering/HitTestResult.h
    M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h
    M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm
    M Source/WebKit/Shared/WebHitTestResultData.cpp
    M Source/WebKit/Shared/WebHitTestResultData.h
    M Source/WebKit/Shared/WebHitTestResultData.serialization.in
    M Source/WebKit/UIProcess/API/APIHitTestResult.h
    M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm

  Log Message:
  -----------
  _WKHitTestResult should expose an elementType property
https://bugs.webkit.org/show_bug.cgi?id=262137
rdar://116078370

Reviewed by Aditya Keerthi and Wenson Hsieh.

Add a elementType property to _WKHitTestResult and plumbing to WebCore::HitTestResult and
WebKit::WebHitTestResultData to support it.

* Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::hasMediaElement const):
* Source/WebCore/rendering/HitTestResult.h:
Added hasMediaElement().
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:
Added _WKHitTestResultElementType and elementType property.
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm:
(-[_WKHitTestResult elementType]):
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::elementTypeFromHitTestResult):
Added, derives WebHitTestResultData::ElementType from WebCore::HitTestResult.
(WebKit::WebHitTestResultData::WebHitTestResultData):
* Source/WebKit/Shared/WebHitTestResultData.h:
* Source/WebKit/Shared/WebHitTestResultData.serialization.in:
Add allowed values for WebHitTestResultData::ElementType and add elementType to WebHitTestResultData.
* Source/WebKit/UIProcess/API/APIHitTestResult.h:
(API::HitTestResult::elementType const):
* Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::TEST):
Added HitTestResultElementTypeNone and HitTestResultElementTypeVideo tests to verify elementType
property is set correctly on _WKHitTestResult.

Canonical link: https://commits.webkit.org/268545@main