[webkit-changes] [WebKit/WebKit] f6ffab: Remove RenderBlockFlow::lineGridBox()
Antti Koivisto
noreply at github.com
Wed Sep 27 14:56:34 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f6ffab2867fbf954b0a9c4b3f30b3354120b81af
https://github.com/WebKit/WebKit/commit/f6ffab2867fbf954b0a9c4b3f30b3354120b81af
Author: Antti Koivisto <antti at apple.com>
Date: 2023-09-27 (Wed, 27 Sep 2023)
Changed paths:
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderLayoutState.cpp
Log Message:
-----------
Remove RenderBlockFlow::lineGridBox()
https://bugs.webkit.org/show_bug.cgi?id=262197
rdar://116128479
Reviewed by Alan Baradlay.
We construct and maintain this LegacyRootInlineBox for the sole purpose of computing
some metrics for the line grid feature. We can just compute those things directly.
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::layoutLineBoxes):
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::lineSnapAdjustment const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutLineGridBox): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::lineGridBox const): Deleted.
(WebCore::RenderBlockFlow::setLineGridBox): Deleted.
* Source/WebCore/rendering/RenderLayoutState.cpp:
(WebCore::RenderLayoutState::computeLineGridPaginationOrigin):
Canonical link: https://commits.webkit.org/268541@main
More information about the webkit-changes
mailing list