[webkit-changes] [WebKit/WebKit] 7b5fdf: [UnifiedPDF] Factor loading code into PDFPluginBase

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b5fdf2f4127b8104c6fe6ccb0b7ec6fff661b30
      https://github.com/WebKit/WebKit/commit/7b5fdf2f4127b8104c6fe6ccb0b7ec6fff661b30
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Factor loading code into PDFPluginBase
https://bugs.webkit.org/show_bug.cgi?id=262163
rdar://116099771

Reviewed by Tim Horton.

Loading code is common to PDFPlugin and UnifiedPDFPlugin, so move it into the base class.
Virtual methods are added to handle incremental loading, which will be migrated in a future PR.

Also add stubs to create and install the PDF document.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::incrementalPDFStreamDidFinishLoading):
(WebKit::PDFPlugin::incrementalPDFStreamDidReceiveData):
(WebKit::PDFPlugin::incrementalPDFStreamDidFail):
(WebKit::PDFPlugin::createPDFDocument):
(WebKit::PDFPlugin::addArchiveResource): Deleted.
(WebKit::PDFPlugin::streamDidFinishLoading): Deleted.
(WebKit::PDFPlugin::streamDidReceiveResponse): Deleted.
(WebKit::PDFPlugin::ensureDataBufferLength): Deleted.
(WebKit::PDFPlugin::streamDidReceiveData): Deleted.
(WebKit::PDFPlugin::streamDidFail): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::tryRunScriptsInPDFDocument):
(WebKit::PDFPluginBase::incrementalPDFStreamDidReceiveData):
(WebKit::PDFPluginBase::incrementalPDFStreamDidFinishLoading):
(WebKit::PDFPluginBase::incrementalPDFStreamDidFail):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::ensureDataBufferLength):
(WebKit::PDFPluginBase::streamDidReceiveResponse):
(WebKit::PDFPluginBase::streamDidReceiveData):
(WebKit::PDFPluginBase::streamDidFinishLoading):
(WebKit::PDFPluginBase::streamDidFail):
(WebKit::PDFPluginBase::addArchiveResource):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::createPDFDocument):
(WebKit::UnifiedPDFPlugin::installPDFDocument):
(WebKit::UnifiedPDFPlugin::scaleFactor const):
(WebKit::UnifiedPDFPlugin::pdfDocumentForPrinting const):
(WebKit::UnifiedPDFPlugin::pdfDocumentSizeForPrinting const):
(WebKit::UnifiedPDFPlugin::streamDidReceiveResponse): Deleted.
(WebKit::UnifiedPDFPlugin::streamDidReceiveData): Deleted.
(WebKit::UnifiedPDFPlugin::streamDidFinishLoading): Deleted.
(WebKit::UnifiedPDFPlugin::streamDidFail): Deleted.

Canonical link: https://commits.webkit.org/268537@main