[webkit-changes] [WebKit/WebKit] 4dfeaf: Fix serialization of “autocomplete” with “webauthn...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dfeafc934022d7c54e3777057f7046ba3430b00
      https://github.com/WebKit/WebKit/commit/4dfeafc934022d7c54e3777057f7046ba3430b00
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt
    M Source/WebCore/html/Autofill.cpp

  Log Message:
  -----------
  Fix serialization of “autocomplete” with “webauthn” token
https://bugs.webkit.org/show_bug.cgi?id=261808

Reviewed by Pascoe.

This change makes WebKit fully conform to the spec requirements at
https://html.spec.whatwg.org/#autofill-processing-model:attr-fe-autocomplete-webauthn
for serializing the value of the “autocomplete” attribute when it
contains a “webauthn” token.

Specifically, this change fixes handling for a condition in a substep of
that spec algorithm that checks against the maximum tokens allowed.
The code was comparing the number of tokens to the maximum number of
allowed tokens but instead needs to compare the value of a (decremented)
index counter to the maximum number of allowed tokens minus 1.

This change gets WebKit passing all cases in the WPT test at
https://wpt.fyi/results/html/semantics/forms/the-form-element/form-autocomplete.html

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
* Source/WebCore/html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement):

Canonical link: https://commits.webkit.org/268520@main