[webkit-changes] [WebKit/WebKit] 46510a: WebVTT Timestamp Object need one leading zero if t...

Kohei Ueno noreply at github.com
Wed Sep 27 03:02:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46510aee943163967d2d9f6d5f99e5e09ce95a52
      https://github.com/WebKit/WebKit/commit/46510aee943163967d2d9f6d5f99e5e09ce95a52
  Author: Kohei Ueno <kohei.ueno119 at gmail.com>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML-expected.txt
    M Source/WebCore/html/track/WebVTTParser.cpp

  Log Message:
  -----------
  WebVTT Timestamp Object need one leading zero if the hours component is less than ten
https://bugs.webkit.org/show_bug.cgi?id=261201

Reviewed by Eric Carlson.

According to the spec, one leading zero is required if the hours
component is less than ten when timestamp construction. This commit updates
the WebVTT parser to follow the spec.

https://www.w3.org/TR/webvtt1/#dom-construction-rules

* LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML-expected.txt:
* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::appendNumber):
(WebCore::serializeTimestamp):
(WebCore::WebVTTTreeBuilder::constructTreeFromToken):

Canonical link: https://commits.webkit.org/268503@main




More information about the webkit-changes mailing list