[webkit-changes] [WebKit/WebKit] eed240: [IFC][Ruby] Place inter-character annotation box

Alan Baradlay noreply at github.com
Tue Sep 26 14:08:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eed2400b535cd02d75e744ebc90dd519cc6729e9
      https://github.com/WebKit/WebKit/commit/eed2400b535cd02d75e744ebc90dd519cc6729e9
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp

  Log Message:
  -----------
  [IFC][Ruby] Place inter-character annotation box
https://bugs.webkit.org/show_bug.cgi?id=262129

Reviewed by Antti Koivisto.

Inter-character annotation boxes are placed to the right of the base and vertically centered (don't support 'ruby-align: start').

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendAtomicInlineLevelDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::handleInlineBoxEnd):
(WebCore::Layout::InlineDisplayContentBuilder::appendIntercharacterRubyAnnotationBox):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::annotationPosition):

Canonical link: https://commits.webkit.org/268479@main




More information about the webkit-changes mailing list