[webkit-changes] [WebKit/WebKit] 0b7d33: [WebGPU] https://webgpu.github.io/webgpu-samples/s...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b7d33831395826f3fdba7417d104da2e50059b3
      https://github.com/WebKit/WebKit/commit/0b7d33831395826f3fdba7417d104da2e50059b3
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantRewriter.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/RenderBundle.h
    M Source/WebGPU/WebGPU/RenderBundle.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] https://webgpu.github.io/webgpu-samples/samples/renderBundles does not load
https://bugs.webkit.org/show_bug.cgi?id=261852
<radar://115810432>

Reviewed by Tadeu Zagallo.

Fixup RenderBundle implementation to the point where
https://webgpu.github.io/webgpu-samples/samples/renderBundles
works as expected.

* Source/WebGPU/WGSL/ConstantRewriter.cpp:
(WGSL::ConstantRewriter::materialize):
Add FIXME to workaround variant not containing the expected value.

* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::maxBuffersPlusVertexBuffersForVertexStage const):
(WebGPU::Device::vertexBufferIndexForBindGroup const):
Return the actual count of buffers.

* Source/WebGPU/WebGPU/RenderBundle.h:
(WebGPU::RenderBundle::create):
(WebGPU::RenderBundle::resources const):
* Source/WebGPU/WebGPU/RenderBundle.mm:
(-[ResourceUsageAndRenderStage initWithUsage:renderStages:]):
(WebGPU::RenderBundle::RenderBundle):
(WebGPU::RenderBundle::currentPipelineState const):
(WebGPU::RenderBundle::depthStencilState const):
(WebGPU::RenderBundle::cullMode const):
(WebGPU::RenderBundle::frontFace const):
(WebGPU::RenderBundle::depthClipMode const):
Save various state which is part of RenderBundle but not Metal's ICBs.

* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::Device::createRenderBundleEncoder):
(WebGPU::RenderBundleEncoder::RenderBundleEncoder):
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
(WebGPU::RenderBundleEncoder::draw):
(WebGPU::RenderBundleEncoder::drawIndexed):
(WebGPU::RenderBundleEncoder::drawIndexedIndirect):
(WebGPU::RenderBundleEncoder::drawIndirect):
(WebGPU::RenderBundleEncoder::finish):
(WebGPU::addResource):
(WebGPU::RenderBundleEncoder::setBindGroup):
(WebGPU::RenderBundleEncoder::setIndexBuffer):
(WebGPU::RenderBundleEncoder::setPipeline):
(WebGPU::RenderBundleEncoder::setVertexBuffer):
RenderBundleEncoder needs to restore previously set buffers on
earlier ICB commands.

* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executeBundles):
Set state which is needed but not part of the ICBs.

Canonical link: https://commits.webkit.org/268454@main