[webkit-changes] [WebKit/WebKit] 26d634: imported/w3c/web-platform-tests/css/css-contain/co...

Jean-Yves Avenard noreply at github.com
Tue Sep 26 04:32:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26d634c7747234e6438dc95115389287b23a5a65
      https://github.com/WebKit/WebKit/commit/26d634c7747234e6438dc95115389287b23a5a65
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  -----------
  imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-replaced.html is a perma-failure
https://bugs.webkit.org/show_bug.cgi?id=262019
rdar://115966158

Reviewed by Youenn Fablet.

Delay moving networkState back to Idle until we have retrieved media's
metadata.

The MediaPlayerPrivateWebM currently load the entire file upfront to build
a sample table. This caused the networkState to move to Idle and stop
delaying the load. As such, the intrinsic dimensions of the video element
were incorrect when the test ran.

Fly-by fix: move the networkState to NETWORK_LOADING once we start receiving
buffers from the network as per https://html.spec.whatwg.org/multipage/media.html#concept-media-load-algorithm.

Covered by existing tests.

* LayoutTests/platform/mac-wk2/TestExpectations: Re-enable tests.
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::loadFinished):
(WebCore::MediaPlayerPrivateWebM::setNaturalSize):
(WebCore::MediaPlayerPrivateWebM::append):

Canonical link: https://commits.webkit.org/268447@main




More information about the webkit-changes mailing list