[webkit-changes] [WebKit/WebKit] 849a8d: Pausing MediaRecorder still continues to call onda...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 849a8db626632e2045a3a5349b5b362dbc870981
      https://github.com/WebKit/WebKit/commit/849a8db626632e2045a3a5349b5b362dbc870981
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    A LayoutTests/http/wpt/mediarecorder/pause-recording-timeSlice-expected.txt
    A LayoutTests/http/wpt/mediarecorder/pause-recording-timeSlice.html
    M Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp
    M Source/WebCore/Modules/mediarecorder/MediaRecorder.h

  Log Message:
  -----------
  Pausing MediaRecorder still continues to call ondataavailable at every timeslice event
https://bugs.webkit.org/show_bug.cgi?id=261964
rdar://115979604

Reviewed by Eric Carlson.

Before the patch, we were firing dataavailable events with zero data in case recorder is using timeSlice but is paused.
We are now stopping the timer to stop fetching data when pausing.
When resuming, we restart the timer with the delay left at pause time.

* LayoutTests/http/wpt/mediarecorder/pause-recording-timeSlice-expected.txt: Added.
* LayoutTests/http/wpt/mediarecorder/pause-recording-timeSlice.html: Added.
* Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::requestData):
(WebCore::MediaRecorder::pauseRecording):
(WebCore::MediaRecorder::resumeRecording):
* Source/WebCore/Modules/mediarecorder/MediaRecorder.h:

Canonical link: https://commits.webkit.org/268433@main