[webkit-changes] [WebKit/WebKit] 67ce0e: Treat huge 'repeatCount' values as invalid

Ahmad Saleem noreply at github.com
Mon Sep 25 16:42:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67ce0e5675816fce4f9989afe2ae1f2af709c16a
      https://github.com/WebKit/WebKit/commit/67ce0e5675816fce4f9989afe2ae1f2af709c16a
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/svg/animations/repeatcount-numeric-limit.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/svg/animations/repeatcount-numeric-limit.tentative.svg
    M Source/WebCore/svg/animation/SVGSMILElement.cpp

  Log Message:
  -----------
  Treat huge 'repeatCount' values as invalid

https://bugs.webkit.org/show_bug.cgi?id=262046

Reviewed by Said Abou-Hallawa.

This patch aligns WebKit with Blink / Chromium and Gecko / Firefox.

Merge: https://chromium.googlesource.com/chromium/src/+/8fcb33ec493a697c5973fed3fa3afaf77bf626db

String::toDouble() can return infinity. This value could either be
treated the same as the 'indefinite' keyword or as invalid. Gecko
appears do the latter so follow suit. It is match Blink and Gecko.

* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(SVGSMILElement::repeatCount):
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/repeatcount-numeric-limit.tentative.svg: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/svg/animations/repeatcount-numeric-limit.tentative-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/268420@main




More information about the webkit-changes mailing list