[webkit-changes] [WebKit/WebKit] 9aea0c: Refactor RenderListBox to use ScrollPosition

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9aea0cafc6c84113c0dd547ea5a3cab42a19ce2f
      https://github.com/WebKit/WebKit/commit/9aea0cafc6c84113c0dd547ea5a3cab42a19ce2f
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderListBox.cpp
    M Source/WebCore/rendering/RenderListBox.h

  Log Message:
  -----------
  Refactor RenderListBox to use ScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=262018
rdar://115965535

Reviewed by Simon Fraser.

The use of `ScrollPosition` is necessary in order to support vertical writing
modes and flipped block directions. Eventually, `RenderListBox` will no longer
assume single-axis scrolling, and a scroll origin of (0, 0).

No behavior change. Subsequent patches will add support and tests for vertical
writing modes.

* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::itemBoundingBoxRect const):
(WebCore::RenderListBox::paintItem):
(WebCore::RenderListBox::listIndexAtOffset const):
(WebCore::RenderListBox::scrollToward):
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::listIndexIsVisible):
(WebCore::RenderListBox::indexOffset const):
(WebCore::RenderListBox::scrollPosition const):
(WebCore::RenderListBox::minimumScrollPosition const):
(WebCore::RenderListBox::maximumScrollPosition const):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::numberOfVisibleItemsInPaddingTop const):
(WebCore::RenderListBox::numberOfVisibleItemsInPaddingBottom const):
(WebCore::RenderListBox::computeFirstIndexesVisibleInPaddingTopBottomAreas):
(WebCore::RenderListBox::scrollTo):
(WebCore::RenderListBox::scrollTop const):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::scrolledToTop const): Deleted.
(WebCore::RenderListBox::scrolledToBottom const): Deleted.
(WebCore::RenderListBox::scrolledToLeft const): Deleted.
(WebCore::RenderListBox::scrolledToRight const): Deleted.
* Source/WebCore/rendering/RenderListBox.h:

Canonical link: https://commits.webkit.org/268414@main