[webkit-changes] [WebKit/WebKit] d3f529: Declarative Web Push: Flatten the JSON structure, ...

Brady Eidson noreply at github.com
Mon Sep 25 13:44:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d3f529899e76b9a2e64ea39fee114fcbfb776f52
      https://github.com/WebKit/WebKit/commit/d3f529899e76b9a2e64ea39fee114fcbfb776f52
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M Source/WebCore/Modules/notifications/NotificationJSONParser.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Declarative Web Push: Flatten the JSON structure, removing the `options` sub-object
https://bugs.webkit.org/show_bug.cgi?id=262055
rdar://116003373

Reviewed by Alex Christensen.

This helps to reconcile the non-optional "default action URL" JSON member with the
completely optional "default action URL" NotificationOptions dictionary member.

Makes describing the JSON simpler, as well as making future additions easier.

* Source/WebCore/Modules/notifications/NotificationJSONParser.cpp:
(WebCore::NotificationJSONParser::parseNotificationPayload):
(WebCore::optionsKey): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

Canonical link: https://commits.webkit.org/268408@main




More information about the webkit-changes mailing list