[webkit-changes] [WebKit/WebKit] cf2e06: MediaPlayerPrivateWebM is disabled with WebKitTest...

Jean-Yves Avenard noreply at github.com
Mon Sep 25 04:28:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf2e0687353fde9afb96ce94f89035e55e029c59
      https://github.com/WebKit/WebKit/commit/cf2e0687353fde9afb96ce94f89035e55e029c59
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/mimesniff/media/media-sniff.window-expected.txt
    M LayoutTests/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt
    M LayoutTests/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt
    M LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt
    M LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt
    M LayoutTests/platform/ios-wk2/TestExpectations
    A LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt
    A LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt
    A LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt
    A LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt
    M LayoutTests/platform/mac-ventura-wk2/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mimesniff/media/media-sniff.window-expected.txt
    M LayoutTests/platform/mac-wk2/TestExpectations
    R LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mimesniff/media/media-sniff.window-expected.txt
    M LayoutTests/platform/mac/TestExpectations
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt
    R LayoutTests/platform/mac/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt
    R LayoutTests/platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt
    R LayoutTests/platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt
    M LayoutTests/platform/mac/media/media-can-play-webm-expected.txt
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  MediaPlayerPrivateWebM is disabled with WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=261993
rdar://115928967

Reviewed by Eric Carlson.

WebKitTestRunner was ignoring the value of the preference to enable
the newer MediaPlayerPrivateWebM (WebM Alternate Player), and as such
wasn't being test, despite being made the default player in bug 261940.

Covered by existing tests.
Amend expectations as previously the WebM player was not availabe on EWS
bots.

* LayoutTests/imported/w3c/web-platform-tests/mimesniff/media/media-sniff.window-expected.txt:
* LayoutTests/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
* LayoutTests/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
* LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
* LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Added.
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mimesniff/media/media-sniff.window-expected.txt: Added.
* LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt
* LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt
* LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt
* LayoutTests/platform/ios-wk2/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt
* LayoutTests/platform/mac-ventura-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mimesniff/media/media-sniff.window-expected.txt: Removed.
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt:
* LayoutTests/platform/mac/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
* LayoutTests/platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
* LayoutTests/platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
* LayoutTests/platform/mac/media/media-can-play-webm-expected.txt:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

Canonical link: https://commits.webkit.org/268393@main




More information about the webkit-changes mailing list