[webkit-changes] [WebKit/WebKit] 1d9858: Unreviewed, revert 268272 at main, causing 0.6% regre...

Mon Sep 25 00:31:48 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d9858247e09327ebd7c7540d9b0c690929c9018
      https://github.com/WebKit/WebKit/commit/1d9858247e09327ebd7c7540d9b0c690929c9018
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/css3/masking/mask-reference-png-fragment-expected.html
    R LayoutTests/css3/masking/mask-reference-png-fragment.html
    R LayoutTests/css3/masking/resources/red-100x100.png
    R LayoutTests/http/tests/css/css-masking/mask-external-svg-fragment-expected.html
    R LayoutTests/http/tests/css/css-masking/mask-external-svg-fragment.html
    R LayoutTests/http/tests/css/css-masking/mask-external-svg-image-expected.html
    R LayoutTests/http/tests/css/css-masking/mask-external-svg-image.html
    R LayoutTests/http/tests/css/css-masking/mask-external-svg-mask-expected.html
    R LayoutTests/http/tests/css/css-masking/mask-external-svg-mask.html
    R LayoutTests/http/tests/css/css-masking/mask-inline-svg-image-expected.html
    R LayoutTests/http/tests/css/css-masking/mask-inline-svg-image.html
    R LayoutTests/http/tests/css/css-masking/mask-inline-svg-mask-expected.html
    R LayoutTests/http/tests/css/css-masking/mask-inline-svg-mask.html
    R LayoutTests/http/tests/css/css-masking/resources/heart.svg
    R LayoutTests/http/tests/css/css-masking/resources/star-heart-fragments.svg
    R LayoutTests/http/tests/css/css-masking/resources/star-heart-masks.svg
    R LayoutTests/http/tests/css/css-masking/resources/star.svg
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/wpe/TestExpectations
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSImageValue.cpp
    M Source/WebCore/platform/graphics/Image.cpp
    M Source/WebCore/platform/graphics/Image.h
    M Source/WebCore/rendering/BorderPainter.cpp
    M Source/WebCore/rendering/CSSFilter.cpp
    M Source/WebCore/rendering/InlineBoxPainter.cpp
    M Source/WebCore/rendering/ReferencedSVGResources.cpp
    M Source/WebCore/rendering/ReferencedSVGResources.h
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/style/FillLayer.cpp
    M Source/WebCore/rendering/style/FillLayer.h
    M Source/WebCore/rendering/style/NinePieceImage.cpp
    M Source/WebCore/rendering/style/StyleCachedImage.cpp
    M Source/WebCore/rendering/style/StyleCachedImage.h
    M Source/WebCore/rendering/style/StyleImage.h
    M Source/WebCore/rendering/style/StyleMultiImage.cpp
    M Source/WebCore/rendering/style/StyleMultiImage.h
    M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
    M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h
    M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
    M Source/WebCore/rendering/svg/SVGResources.cpp
    M Source/WebCore/svg/graphics/SVGImage.cpp
    M Source/WebCore/svg/graphics/SVGImage.h
    R Source/WebCore/svg/graphics/SVGResourceImage.cpp
    R Source/WebCore/svg/graphics/SVGResourceImage.h

  Log Message:
  -----------
  Unreviewed, revert 268272 at main, causing 0.6% regression in SP3
https://bugs.webkit.org/show_bug.cgi?id=262027
rdar://115975331

* LayoutTests/TestExpectations:
* LayoutTests/css3/masking/mask-reference-png-fragment-expected.html: Removed.
* LayoutTests/css3/masking/mask-reference-png-fragment.html: Removed.
* LayoutTests/css3/masking/resources/red-100x100.png: Removed.
* LayoutTests/http/tests/css/css-masking/mask-external-svg-fragment-expected.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-external-svg-fragment.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-external-svg-image-expected.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-external-svg-image.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-external-svg-mask-expected.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-external-svg-mask.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-inline-svg-image-expected.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-inline-svg-image.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-inline-svg-mask-expected.html: Removed.
* LayoutTests/http/tests/css/css-masking/mask-inline-svg-mask.html: Removed.
* LayoutTests/http/tests/css/css-masking/resources/heart.svg: Removed.
* LayoutTests/http/tests/css/css-masking/resources/star-heart-fragments.svg: Removed.
* LayoutTests/http/tests/css/css-masking/resources/star-heart-masks.svg: Removed.
* LayoutTests/http/tests/css/css-masking/resources/star.svg: Removed.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSImageValue.cpp:
* Source/WebCore/platform/graphics/Image.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/graphics/Image.h:
(WebCore::Image::isSVGImageForContainer const):
(WebCore::Image::isSVGResourceImage const): Deleted.
* Source/WebCore/rendering/BorderPainter.cpp:
(WebCore::BorderPainter::paintBorder):
(WebCore::BorderPainter::paintNinePieceImage):
* Source/WebCore/rendering/CSSFilter.cpp:
(WebCore::referenceFilterElement):
* Source/WebCore/rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paintMask):
(WebCore::InlineBoxPainter::paintDecorations):
* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::ReferencedSVGResources::referencedRenderResource): Deleted.
* Source/WebCore/rendering/ReferencedSVGResources.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::paintMaskImages):
(WebCore::RenderBox::repaintLayerRectsForImage):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::borderImageIsLoadedAndCanBeRendered const):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupClipPath):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::canDirectlyCompositeBackgroundBackgroundImage):
(WebCore::hasPaintedBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::contentChanged):
* Source/WebCore/rendering/style/FillLayer.cpp:
(WebCore::FillLayer::imagesAreLoaded const):
* Source/WebCore/rendering/style/FillLayer.h:
* Source/WebCore/rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::paint const):
* Source/WebCore/rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::canRender const):
(WebCore::StyleCachedImage::isLoaded const):
(WebCore::StyleCachedImage::imageSize const):
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerContextForRenderer):
(WebCore::StyleCachedImage::image const):
(WebCore::StyleCachedImage::renderSVGResource const): Deleted.
* Source/WebCore/rendering/style/StyleCachedImage.h:
* Source/WebCore/rendering/style/StyleImage.h:
(WebCore::StyleImage::isLoaded const):
(WebCore::StyleImage::hasImage const):
(WebCore::StyleImage::reresolvedURL const): Deleted.
* Source/WebCore/rendering/style/StyleMultiImage.cpp:
(WebCore::StyleMultiImage::isLoaded const):
* Source/WebCore/rendering/style/StyleMultiImage.h:
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceMasker::drawContentIntoContext): Deleted.
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.h:
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeResources):
* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
* Source/WebCore/svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::rootElement const):
* Source/WebCore/svg/graphics/SVGImage.h:
* Source/WebCore/svg/graphics/SVGResourceImage.cpp: Removed.
* Source/WebCore/svg/graphics/SVGResourceImage.h: Removed.

Canonical link: https://commits.webkit.org/268391@main